| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small review comment on pg_checksums |
| Date: | 2019-06-07 06:30:35 |
| Message-ID: | CAD21AoCd3PPPDVisu54nvKdpwx3kOsWo627TdD74jBxacbGcFw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 6, 2019 at 10:21 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Jun 06, 2019 at 05:16:30PM +0900, Masahiko Sawada wrote:
> > So I'd like to propose a small fix for that; move the comment to the
> > right place and add another comment. Please find an attached small
> > patch.
>
> No objections to that. Perhaps we should also mention that this does
> not protect from someone starting the cluster concurrently and that
> the reason why we require a clean shutdown is that we may get checksum
> failures because of torn pages?
Agreed. Please find an attached patch.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix_pg_checksums_v2.patch | application/octet-stream | 838 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-06-07 06:44:14 | Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold" |
| Previous Message | Masahiko Sawada | 2019-06-07 06:26:25 | Re: [HACKERS] Block level parallel vacuum |