Re: Small review comment on pg_checksums

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small review comment on pg_checksums
Date: 2019-06-06 13:21:28
Message-ID: 20190606132128.GB1978@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 06, 2019 at 05:16:30PM +0900, Masahiko Sawada wrote:
> So I'd like to propose a small fix for that; move the comment to the
> right place and add another comment. Please find an attached small
> patch.

No objections to that. Perhaps we should also mention that this does
not protect from someone starting the cluster concurrently and that
the reason why we require a clean shutdown is that we may get checksum
failures because of torn pages?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-06-06 14:23:23 Re: Pluggable Storage - Andres's take
Previous Message Ian Barwick 2019-06-06 13:19:05 doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"