Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Sergei Kornilov <sk(at)zsrv(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Indicate anti-wraparound autovacuum in log_autovacuum_min_duration
Date: 2018-07-24 09:02:00
Message-ID: CAD21AoCRA78Uevbe0soqOjueb=qysfA3jqiDSTQFa0J8O6y2Cw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 21, 2018 at 6:26 PM, Sergei Kornilov <sk(at)zsrv(dot)org> wrote:
> Hello
>
>> Yes, a bit more verbosity would be nice for that. Using the term
>> "anti-wraparound" directly in the logs makes the most sense?
> I used "(to prevent wraparound)" to looks like reporting in pg_stat_activity. As far i can see currently we not using "anti-wraparound" for user messages.
> On the other hand we using anti-wraparound in docs, so i can change wording.

+1 for "to prevent wraparound".

>
>> The patch could be made simpler by using empty strings with a single
>> ereport() call.
> How about proper translate in this case? Currently we translate full line "automatic vacuum of table \"%s.%s.%s\": index scans: %d\n" before ereport call.
>

Yeah, for translation I think it's better to make full lines. When we
added "aggressive" to autovacuum logs (commit b55509) we've done the
same thing.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergei Kornilov 2018-07-24 09:05:36 Re: Online enabling of checksums
Previous Message Amit Langote 2018-07-24 08:50:09 Re: [report] memory leaks in COPY FROM on partitioned table