Re: Subscription code improvements

On Mon, Aug 7, 2017 at 10:22 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 8/7/17 00:27, Masahiko Sawada wrote:
>>>> However, even with this patch there is still an issue that NOTICE
>>>> messages "removed subscription for table public.t1" can be appeared
>>>> even if we rollback ALTER SUBSCRIPTION REFRESH command as I mentioned
>>>> on earlier thread. Since I think this behaviour will confuse users who
>>>> check server logs I'd like to deal with it, I don't have a good idea
>>>> though.
>>>
>>> Maybe we can just remove those messages?
>>>
>>> We don't get messages when we create a subscription about which tables
>>> are part of it. So why do we need such messages when we refresh a
>>> subscription?
>>
>> I think that the messages is useful when we add/remove tables to/from
>> the publication and then refresh the subscription, so we might want to
>> change it to DEBUG rather than elimination.
>
> Good idea. Done that way.
>

Thank you!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center