| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, andrewbille(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: BUG #17385: "RESET transaction_isolation" inside serializable transaction causes Assert at the transaction end |
| Date: | 2022-07-01 05:11:47 |
| Message-ID: | CAD21AoC8FQqHY8knG7+6-eQe39wjXPtqyki29OAb5OHhq7-p+Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Jun 29, 2022 at 3:48 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Jun 28, 2022 at 03:58:41PM +0900, Masahiko Sawada wrote:
> > Agreed. I've attached an updated patch.
>
> +#define GUC_NO_RESET 0x400000 /* not support RESET and save */
>
> It is a bit sad to see this new flag with this number, separated from
> its cousin properties. Could it be better to reorganize the flag
> values and give more room to the properties? The units for memory and
> time could go first, for example.
It seems a good idea, I'll update it in the next version patch.
>
> +CREATE FUNCTION errfunc() RETURNS int LANGUAGE SQL AS 'SELECT 1'
> +SET transaction_read_only = on; -- error
> +ERROR: parameter "transaction_read_only" cannot be reset
> Well, this is confusing when setting a GUC_NO_RESET in the context of
> GUC_ACTION_SAVE.
Right, how about "parameter %s cannot be set"?
> By the way, what about "seed"?
Resetting seed is no-op so it might be better to throw an error when
resetting the seed rather than doing nothing silently.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-01 05:16:59 | Re: pg15 beta2 bug:cause by logcial replation |
| Previous Message | houzj.fnst@fujitsu.com | 2022-07-01 04:09:22 | RE: pg15 beta2 bug:cause by logcial replation |