Re: pg_stat_get_autovacuum_scores ignores the main table's reloptions for TOAST tables

On Fri, Aug 28, 2026 at 8:16 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Fri, Aug 28, 2026 at 10:02:42AM -0500, Nathan Bossart wrote:
> > Here is a patch.
>
> Sorry for the noise. I noticed some silly mistakes in v1, so here's a v2
> with those fixed.

Thank you for making the patch quickly! The patch looks good to me. A nitpick:

+ if (found && hentry->ar_hasrelopts)
+ avopts = &hentry->ar_reloptions;

ar_hasrelopts is always true here, since entries are only created when
extract_autovac_opts() returns non-NULL, so the second conjunct is
redundant actually. Having said that, it seems safer for future
changes and keeping it for symmetry with do_autovacuum() seems fine to
me.

Do we want to have regression tests for it? FWIW no test exercises
pg_stat_get_autovacuum_scores(). The only reference in the tree is the
view definition in rules.out. That's presumably why this went
unnoticed.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com