Re: Adding a range check on the sequence index from the publisher.

On Mon, Sep 21, 2026 at 9:10 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Sep 22, 2026 at 1:22 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I've attached the patch to fix it. Feedback is very welcome.
> >
>
> Thanks, fix LGTM. BTW, on similar lines, we can change seqRow[0] to
> INT4OID from INT8OID in copy_sequences()[1]. Since
> libpqrcv_processTuples uses the declared type's input function, the
> value is parsed by int8in and then silently truncated to its low 32
> bits. This can be risky too.

Right. It doesn't actually lead to OOB writes so I was thinking of
fixing it in a separate patch. Having said that, it would be
reasonable to fix both at the same time.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com