Re: Adding a range check on the sequence index from the publisher.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding a range check on the sequence index from the publisher.
Date: 2026-09-22 04:09:49
Message-ID: CAA4eK1KTHhnVG=0z58f7968ksNW4dD3WyUi3755k6HH27ookcA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 22, 2026 at 1:22 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> I've attached the patch to fix it. Feedback is very welcome.
>

Thanks, fix LGTM. BTW, on similar lines, we can change seqRow[0] to
INT4OID from INT8OID in copy_sequences()[1]. Since
libpqrcv_processTuples uses the declared type's input function, the
value is parsed by int8in and then silently truncated to its low 32
bits. This can be risky too.

[1]:
Oid seqRow[REMOTE_SEQ_COL_COUNT] = {INT8OID,

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message solai v 2026-09-22 04:13:31 Re: Prevent object capture in CREATE/ALTER EXTENSION scripts
Previous Message ZizhuanLiu X-MAN 2026-09-22 04:07:49 Re: Optimize MCV stats for sortable types and utilize sorted-order properties