Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com>
Cc: "Boris P(dot) Korzun" <drtr0jan(at)yandex(dot)ru>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES
Date: 2021-10-01 14:13:45
Message-ID: CAD21AoBrCbjiJt3OCDQCLrM6OQOxjV9cAyM6bn4=SjHq0konBQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, Sep 22, 2021 at 10:31 AM Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com> wrote:
>
> Hi Boris,
>
> Actually, because I am a PG beginner, I am not familiar with the rules of the community. What extra work do I need to do to submit to the upstream? This bug discussion doesn't seem to see the concern of others.

As far as I checked this bug still exists in all supported branches
(from 10 to 14, and HEAD). I'd recommend adding this patch to the next
commit fest so as not to forget, if not yet.

I agree with your analysis on this bug. For non-default
(defaclnamespace != 0) entries, their acl should be compared to NULL.

The fix also looks good to me. But I think it'd be better to add tests for this.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2021-10-01 16:53:08 Re: BUG #17207: Bad cost estimate of Merge Join despite correct row estimate
Previous Message Devrim Gündüz 2021-10-01 14:02:34 Re: BUG #17208: Download fails when running 'yum install postgresql96'

Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2021-10-01 14:20:01 Re: Using indexUnchanged with nbtree
Previous Message Amit Langote 2021-10-01 13:55:44 Re: Multi-Column List Partitioning