| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, 李海龙 <hailong(dot)li(at)qunar(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: when set track_commit_timestamp on, database system abort startup |
| Date: | 2018-09-27 09:18:41 |
| Message-ID: | CAD21AoB_Kp6Cz8BvLkXdr-ZztTh8O+EVzFjv6bfMpSEodZQu+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 26, 2018 at 10:34 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Sep 25, 2018 at 11:54:53PM +0900, Masahiko Sawada wrote:
> > Can we use "XLOG_PARAMETER_CHANGE record" instead of "record
> > XLOG_PARAMETER_CHANGE" at the second hunk because the comment of the
> > first hunk uses it. The other part of this patch looks good to me.
>
> Let's use your suggestion, and committed down to 9.5 where this fix
> applies. The TAP test is only present in v11 and above. I have also
> noticed some comment which became incorrect after the fix, so I changed
> them on the way.
Thank you!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-09-27 09:23:13 | Re: executor relation handling |
| Previous Message | David Rowley | 2018-09-27 09:15:50 | Re: executor relation handling |