Re: when set track_commit_timestamp on, database system abort startup

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, 李海龙 <hailong(dot)li(at)qunar(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: when set track_commit_timestamp on, database system abort startup
Date: 2018-09-26 01:34:01
Message-ID: 20180926013401.GF1659@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 25, 2018 at 11:54:53PM +0900, Masahiko Sawada wrote:
> Can we use "XLOG_PARAMETER_CHANGE record" instead of "record
> XLOG_PARAMETER_CHANGE" at the second hunk because the comment of the
> first hunk uses it. The other part of this patch looks good to me.

Let's use your suggestion, and committed down to 9.5 where this fix
applies. The TAP test is only present in v11 and above. I have also
noticed some comment which became incorrect after the fix, so I changed
them on the way.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-09-26 01:38:51 Re: pgsql: Remove absolete function TupleDescGetSlot().
Previous Message Thomas Munro 2018-09-26 01:29:08 Re: Shared buffer access rule violations?