| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Jim Nasby <jim(dot)nasby(at)openscg(dot)com> |
| Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Report the number of skipped frozen pages by manual VACUUM |
| Date: | 2017-03-10 11:08:42 |
| Message-ID: | CAD21AoBWNmdL5CHWUHKDaMgD=F1Vj-w28ZBNhYRXQEhOMxsLaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 10, 2017 at 3:58 PM, Jim Nasby <jim(dot)nasby(at)openscg(dot)com> wrote:
> On 3/6/17 8:34 PM, Masahiko Sawada wrote:
>>
>> I don't think it can say "1 frozen pages" because the number of
>> skipped pages according to visibility map is always more than 32
>> (SKIP_PAGES_THRESHOLD).
>
>
> That's just an artifact of how the VM currently works. I'm not a fan of
> cross dependencies like that unless there's a pretty good reason.
Thank you for the comment.
Agreed. Attached fixed version patch.
> BTW, I think there's already a function that handles the pluralization for
> you. IIRC it's one of the things you can add to an ereport() call.
What is the function name?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| report_frozen_skipped_pages_v3.patch | application/octet-stream | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-03-10 11:17:54 | Re: Speed up Clog Access by increasing CLOG buffers |
| Previous Message | Tels | 2017-03-10 11:01:10 | Re: Parallel Append implementation |