Re: Missing generated column in ALTER TABLE ADD COLUMN doc

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing generated column in ALTER TABLE ADD COLUMN doc
Date: 2019-06-10 09:09:53
Message-ID: CAD21AoBVxjWUweb7JPW-CEEZxy7vqZwFeyzYm+j2gbf=+vs_ZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 10, 2019 at 5:05 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jun 07, 2019 at 06:07:34PM +0900, Masahiko Sawada wrote:
> > We support ALTER TABLE ADD COLUMN .. GENERATED ALWAYS AS .. but the
> > doc is missing it. Attached small patch fixes this.
>
> Your patch updates the section related to constraint_name. Don't you
> need an extra line for the "action" part?

We already have the following line in action part but you mean we need
an extra line for that?

ADD [ COLUMN ] [ IF NOT EXISTS ] column_name data_type [ COLLATE
collation ] [ column_constraint [ ... ] ]

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2019-06-10 09:10:24 Re: Should we warn against using too many partitions?
Previous Message Etsuro Fujita 2019-06-10 08:53:20 postgres_fdw: unordered C includes