Re: Missing generated column in ALTER TABLE ADD COLUMN doc

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing generated column in ALTER TABLE ADD COLUMN doc
Date: 2019-06-11 04:02:28
Message-ID: 20190611040228.GA2132@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 10, 2019 at 06:09:53PM +0900, Masahiko Sawada wrote:
> We already have the following line in action part but you mean we need
> an extra line for that?
>
> ADD [ COLUMN ] [ IF NOT EXISTS ] column_name data_type [ COLLATE
> collation ] [ column_constraint [ ... ] ]

I was looking at the grammar extensions for ADD GENERATED and noticed
what looked like inconsistencies, but your patch as well as the parsed
query are right. Committed, thanks!
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhang, Jie 2019-06-11 04:10:02 RE: [PATCH] memory leak in ecpglib
Previous Message Andres Freund 2019-06-11 03:22:49 rebased background worker reimplementation prototype