From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Perform streaming logical transactions by background workers and parallel apply |
Date: | 2022-05-10 05:09:14 |
Message-ID: | CAD21AoB8YTFSXcA0OGUN4DOvqyUzgkcUKYZuME5nmme9eOT1JQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, May 4, 2022 at 8:44 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Tue, May 3, 2022 at 5:16 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> ...
>
> > Avoiding unexpected differences like this is why I suggested the
> > option should have to be explicitly enabled instead of being on by
> > default as it is in the current patch. See my review comment #14 [1].
> > It means the user won't have to change their existing code as a
> > workaround.
> >
> > ------
> > [1] https://www.postgresql.org/message-id/CAHut%2BPuqYP5eD5wcSCtk%3Da6KuMjat2UCzqyGoE7sieCaBsVskQ%40mail.gmail.com
> >
>
> Sorry I was wrong above. It seems this behaviour was already changed
> in the latest patch v5 so now the option value 'on' means what it
> always did. Thanks!
Having it optional seems a good idea. BTW can the user configure how
many apply bgworkers can be used per subscription or in the whole
system? Like max_sync_workers_per_subscription, is it better to have a
configuration parameter or a subscription option for that? If so,
setting it to 0 probably means to disable the parallel apply feature.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2022-05-10 07:02:05 | Re: Support logical replication of DDLs |
Previous Message | Masahiko Sawada | 2022-05-10 05:04:42 | Re: Perform streaming logical transactions by background workers and parallel apply |