Re: BUG #19556: Segmentation fault in test_decoding

On Thu, Jul 23, 2026 at 11:24 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Wed, Jul 22, 2026 at 11:50 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Thu, Jul 23, 2026 at 7:47 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > > Thank you for the patch. I like the approach the proposed patch does.
> > > I've made a patch for PG18+ that fixes both issues with regression
> > > tests. For PG17 or earlier, the patch doesn't need the changes in
> > > ReorderBufferPrepare() but has the same regression tests.
> > >
> >
> > The patch LGTM. One minor point: Shall we retain the earlier comments
> > (We send the prepare for the concurrently aborted xacts so that later
> > when rollback prepared is decoded and sent, the downstream should be
> > able to rollback such a xact. See comments atop DecodePrepare.)? This
> > makes it clear why we are sending prepare for concurrent abort cases.
>
> Thank you for reviewing the 0001 patch! Yes, I agree to retain the
> comment. I'll update the patch and push it early next week.
>

I prepared the patches for all branches. I'm going to push them
tomorrow if there is no further comment.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com