Re: [HACKERS] Subscription code improvements

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Subscription code improvements
Date: 2018-01-24 07:33:26
Message-ID: CAD21AoAr=1_3J0vUJZchMiFRtu=AZ+5a=Ki7WTY=GS7CCYSGYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 23, 2018 at 7:58 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> Greetings,
>
> * Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
>> On Fri, Aug 18, 2017 at 2:09 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> > On Thu, Aug 17, 2017 at 8:17 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> >> On Thu, Aug 17, 2017 at 9:10 AM, Peter Eisentraut
>> >> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> >>> On 8/8/17 05:58, Masahiko Sawada wrote:
>> >>>> Are you planning to work on remaining patches 0005 and 0006 that
>> >>>> improve the subscription codes in PG11 cycle? If not, I will take over
>> >>>> them and work on the next CF.
>> >>>
>> >>> Based on your assessment, the remaining patches were not required bug
>> >>> fixes. So I think preparing them for the next commit fest would be great.
>> >>>
>> >>
>> >> Thank you for the comment.
>> >>
>> >> After more thought, since 0001 and 0003 patches on the first mail also
>> >> improve the subscription codes and are worth to be considered, I
>> >> picked total 4 patches up and updated them. I'm planning to work on
>> >> these patches in the next CF.
>> >>
>> >
>> > Added this item to the next commit fest.
>>
>> The patch set fails to apply. Please provide a rebased version. I am
>> moving this entry to next CF with waiting on author as status.
>
> Masahiko Sawada, this patch is still in Waiting on Author and hasn't
> progressed in a very long time. Is there any chance you'll be able to
> provide an updated patch soon for review? Or should this patch be
> closed out?
>

Thank you for notification. Since it seems to me that no one is
interested in this patch, it would be better to close out this patch.
This patch is a refactoring patch but subscription code seems to work
fine so far. If a problem appears around subscriptions, I might
propose it again.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gaddam Sai Ram 2018-01-24 07:37:16 Help needed in using 'on_dsm_detach' callback
Previous Message Andres Freund 2018-01-24 07:20:38 JIT compiling with LLVM v9.0