Re: max_sync_workers_per_subscription is missing in postgresql.conf

On Tue, Apr 11, 2017 at 1:39 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Mon, Apr 10, 2017 at 9:39 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
>> <petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
>>> On 10/04/17 07:16, Masahiko Sawada wrote:
>>>> Hi all,
>>>>
>>>> Attached a patch for $subject.
>>>>
>>>> I added this parameter into "Asynchronous Behavior" section of
>>>> "RESOURCE" section. But GUC parameter for subscriber now is written in
>>>> this section, in spite of there is "REPLICATION" section. I think that
>>>> we can coordinate these parameters to not confuse user. For example in
>>>> documentation, these parameters are described in "19.6.4. Subscribers"
>>>> section of "19.6. Replication" section. Thought?
>
> Yes, I think that we should not only add the parameter into
> postgresql.conf.sample
> but also
>
> - add REPLICATION_SUBSCRIBERS into config_group
> - mark max_logical_replication_workers and max_sync_workers_per_subscription
> as REPLICATION_SUBSCRIBERS parameters, in guc.c
> - move those parameters into "Subscribers" section in postgresql.conf.sample

+1

> The attached patch does these.

The patch looks good to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center