| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Greg Nancarrow <gregn4422(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2021-08-30 07:06:55 |
| Message-ID: | CAD21AoA5HrhXqwbYLpSobGzV6rWoJmH3-NB9J3YarKDwARBj4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 27, 2021 at 8:03 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Fri, Aug 27, 2021 at 1:36 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Thu, Aug 26, 2021 at 6:24 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > > On Thu, Aug 26, 2021 at 9:11 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > >
> > > >
> > > > Okay, changed accordingly. Additionally, I have changed the code which
> > > > sets timestamp to (unset) when it is 0 so that it won't display the
> > > > timestamp in that case. I have made few other cosmetic changes in the
> > > > attached patch. See and let me know what you think of it?
> > >
> > > Thank you for the patch!
> > >
> > > Agreed with these changes. The patch looks good to me.
> > >
> >
> > Pushed, feel free to rebase and send the remaining patch set.
>
> Thanks!
>
> I'll post the updated version patch on Monday.
I've attached rebased patches. 0004 patch is not the scope of this
patch. It's borrowed from another thread[1] to fix the assertion
failure for newly added tests. Please review them.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-Add-pg_stat_subscription_errors-statistics-view.patch | application/octet-stream | 47.5 KB |
| v12-0003-Add-skip_xid-option-to-ALTER-SUBSCRIPTION.patch | application/octet-stream | 39.7 KB |
| v12-0004-Using-fileset-more-effectively-in-the-apply-work.patch | application/octet-stream | 18.7 KB |
| v12-0002-Add-RESET-command-to-ALTER-SUBSCRIPTION-command.patch | application/octet-stream | 13.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-08-30 07:29:19 | Re: Estimating HugePages Requirements? |
| Previous Message | Peter Eisentraut | 2021-08-30 07:02:15 | Re: list of acknowledgments for PG14 |