| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix slot synchronization with two_phase decoding enabled |
| Date: | 2025-05-21 23:02:30 |
| Message-ID: | CAD21AoA-t11f7Ru=Md-iYfc+OeCN5p41rAae-T7PZozDazYwQA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 9, 2025 at 5:09 AM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> On Thu, May 8, 2025 at 11:35 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > On Wed, May 7, 2025 at 4:36 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> > >
> > >
> > > Attached is the v13 patch with the above comments addressed.
> > >
> > > --
> >
> > Thanks for the patch.
> >
> > I think we can have the restriction mentioned under the 'two_phase'
> > section as well along with the 'failover' section in the CREATE
> > SUBSCRIPTION doc, similar to what we have in CREATE_REPLICATION_SLOT.
> >
> > Apart from this, I have no more comments.
> >
>
> Thanks for the review.
> Please find the v14 patch, updated with the above suggestion and
> rephrased changes in alter_subscription.sgml with the missing links.
Thank you for updating the patch. I'm reviewing the v14 patch and will
share some comments tomorrow.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-05-21 23:11:09 | Re: Statistics Import and Export |
| Previous Message | Masahiko Sawada | 2025-05-21 22:10:48 | Re: Assert("vacrel->eager_scan_remaining_successes > 0") |