| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix slot synchronization with two_phase decoding enabled |
| Date: | 2025-05-09 12:09:12 |
| Message-ID: | CABdArM7Qnv1niNGUtYWPrzJ7ztFDKVdLu6NOxse18mTOeYoKaA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 8, 2025 at 11:35 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Wed, May 7, 2025 at 4:36 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> >
> > Attached is the v13 patch with the above comments addressed.
> >
> > --
>
> Thanks for the patch.
>
> I think we can have the restriction mentioned under the 'two_phase'
> section as well along with the 'failover' section in the CREATE
> SUBSCRIPTION doc, similar to what we have in CREATE_REPLICATION_SLOT.
>
> Apart from this, I have no more comments.
>
Thanks for the review.
Please find the v14 patch, updated with the above suggestion and
rephrased changes in alter_subscription.sgml with the missing links.
--
Thanks,
Nisha
| Attachment | Content-Type | Size |
|---|---|---|
| v14-0001-PG17-Approach-3-Fix-slot-synchronization-for-two.patch | application/x-patch | 26.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alena Rybakina | 2025-05-09 12:31:11 | Re: Vacuum statistics |
| Previous Message | Tomas Vondra | 2025-05-09 12:04:49 | strange perf regression with data checksums |