Re: Fix stale comment in parallel_vacuum_main().

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix stale comment in parallel_vacuum_main().
Date: 2026-07-29 16:53:16
Message-ID: CAD21AoA+Fu1ff8oj_V=GUSpuY9Y7m50rHmJj_q+49TBqdeHrLA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 28, 2026 at 6:54 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Tue, Jul 28, 2026 at 11:24 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > > I agree with your analysis. And the proposed comment looks clear to
> > > me. Will push the patch barring any objections.
>
> Thanks for taking a look at it.
>
> > After reviewing the new comment closely, I think it's better to
> > mention the PROC_VACUUM_FOR_WRAPAROUND flag too as this is also used
> > for autovacuums. I've attached the updated patch, please review it.
>
> Yes, it looks good to me.

Thank you for reviewing the change. Pushed.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mihail Nikalayeu 2026-07-29 17:01:00 Re: [SP-]GiST IOS visibility bug (was: Why doens't GiST require super-exclusive lock)
Previous Message Tristan Partin 2026-07-29 16:28:27 Re: meson: avoid PATH bloat from NLS .mo targets in tmp_install test setup