| From: | Kiran Kaki <itskkpg(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | surya poondla <suryapoondla4(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: pg_walinspect: fix LSN validation messages and empty range handling |
| Date: | 2026-09-23 23:13:54 |
| Message-ID: | CAD0dvCSshf7=JwV7WXdO=+=7mEYUaqQyQ6mmwrmxVm+_JnU+=Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Chao
>
> PFA v5:
>
> * 0001: only added Surya as a reviewed in the commit message
> * 0002: addressed Surya’s review comments
>
Thanks for addressing the review comments . All four issues are fixed in v5.
Reviewed and tested on master (d39fda1cc4):
- Both patches apply cleanly.
- Build succeeds.
- pg_walinspect tests pass.
- psql tests pass.
- Core regression tests pass.
- Manually verified: ERROR: skip WAL location (LSN 0/00012345) must be
greater than or equal to origin LSN 0/00012346
Looks ready for a committer.
Regards,
Kiran Kaki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-09-23 23:48:19 | Re: Adding a range check on the sequence index from the publisher. |
| Previous Message | Sehrope Sarkuni | 2026-09-23 22:51:14 | Re: Speed up lpad() and rpad() for one-byte padding strings |