Re: pgsql: Add the "snapshot too old" feature

From: Kevin Grittner <kgrittn(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add the "snapshot too old" feature
Date: 2016-04-08 22:31:46
Message-ID: CACjxUsNfiDC2SE9VwsGWF3mLoLbCoDXZSWu2W9WgTsBLOQfWzQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Apr 8, 2016 at 5:04 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Kevin Grittner <kgrittn(at)gmail(dot)com> writes:
>> I see that there are failures on buildfarm Windows machines.
>> Makefiles are not my strong suit, and I don't have access to a
>> Windows machine for builds. I'll start digging, but if someone can
>> help me with that, it would be much appreciated.
>
> I think you need to add snapshot_too_old to @contrib_excludes in
> Mkvcbuild.pm to stop that file from thinking that this module
> contains anything to build. Not sure if anything else needs to be
> done to get the MSVC script to run the test the module embodies,
> but that would at least let it get further than it's getting now.

Thanks! Pushed.

We'll see what happens now....

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2016-04-08 23:24:20 pgsql: Support \crosstabview in psql
Previous Message Kevin Grittner 2016-04-08 22:28:00 pgsql: Add snapshot_too_old to NSVC @contrib_excludes

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-04-08 22:41:21 Re: VS 2015 support in src/tools/msvc
Previous Message Tom Lane 2016-04-08 22:04:55 Re: pgsql: Add the "snapshot too old" feature