Re: pgsql: Add the "snapshot too old" feature

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kevin Grittner <kgrittn(at)gmail(dot)com>
Cc: "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add the "snapshot too old" feature
Date: 2016-04-08 22:04:55
Message-ID: 5493.1460153095@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Kevin Grittner <kgrittn(at)gmail(dot)com> writes:
> I see that there are failures on buildfarm Windows machines.
> Makefiles are not my strong suit, and I don't have access to a
> Windows machine for builds. I'll start digging, but if someone can
> help me with that, it would be much appreciated.

I think you need to add snapshot_too_old to @contrib_excludes in
Mkvcbuild.pm to stop that file from thinking that this module
contains anything to build. Not sure if anything else needs to be
done to get the MSVC script to run the test the module embodies,
but that would at least let it get further than it's getting now.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2016-04-08 22:28:00 pgsql: Add snapshot_too_old to NSVC @contrib_excludes
Previous Message Tom Lane 2016-04-08 21:53:35 Re: pgsql: Add the "snapshot too old" feature

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2016-04-08 22:31:46 Re: pgsql: Add the "snapshot too old" feature
Previous Message Tom Lane 2016-04-08 21:53:35 Re: pgsql: Add the "snapshot too old" feature