Re: Implicit conversion from int64 to int32 when calling hash_get_num_entries

From: Karina Litskevich <litskevichkarina(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Implicit conversion from int64 to int32 when calling hash_get_num_entries
Date: 2026-08-10 12:29:49
Message-ID: CACiT8ibdeExQDunGRVCtSyVfD-WrbQ_moEV-kr1s-gpb8z71rw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 4, 2026 at 12:07 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> I had a look at the patch and came up with the attached v2. I've separated the
> pgver change into its own patch as it's unrelated from the hash_get_num_entries
> change. For 0001 I also think we should cast usages of pgss_max when compated
> to hash_get_num_entries to make this complete, to clarify the code.
>

I don't mind the changes.
Thank you for your attention to the patch!

Best regards,
Karina Litskevich
Postgres Professional: http://postgrespro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ian Lawrence Barwick 2026-08-10 12:39:04 Re: pg_control_checkpoint(): add "data_checksum_version" (Pg19)?
Previous Message Karina Litskevich 2026-08-10 12:21:39 Re: Implicit conversion from int64 to int32 when calling hash_get_num_entries