| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Karina Litskevich <litskevichkarina(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Implicit conversion from int64 to int32 when calling hash_get_num_entries |
| Date: | 2026-08-04 09:06:56 |
| Message-ID: | AC6B5001-A468-4961-8CC9-FBD3368570D5@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I had a look at the patch and came up with the attached v2. I've separated the
pgver change into its own patch as it's unrelated from the hash_get_num_entries
change. For 0001 I also think we should cast usages of pgss_max when compated
to hash_get_num_entries to make this complete, to clarify the code.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-Use-correct-data-type-for-version-identifier.patch | application/octet-stream | 1.1 KB |
| v2-0001-Use-int64-for-number-of-entries-in-pg_stat_statem.patch | application/octet-stream | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-08-04 09:10:06 | Re: Add more tab=completion rules for DROP PROPERTY GRAPH |
| Previous Message | Nisha Moond | 2026-08-04 08:42:00 | Re: Support EXCEPT for TABLES IN SCHEMA publications |