| From: | Nadav Shatz <nadav(at)tailorbrands(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | pgpool-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Removing support for FE/BE protocol version 2 |
| Date: | 2026-10-14 06:08:55 |
| Message-ID: | CACeKOO0As89UhOx0-aZJx8QeFh2b2QGc06sy0z0AcHyXHYL9Sg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgpool-hackers |
Thank YOU!
great work on this.
Best,
On Wed, Oct 14, 2026 at 2:00 AM Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
> Hi Nadav,
>
> Thanks for the review!
>
> > Hi,
> >
> > Thanks for v5!
> >
> > Agreed on handling protoMajor/protoMinor in pool_get_cp() as a
> > separate patch.
> >
> > One small leftover: the 010 test stub
> > (src/test/regression/tests/010.rewrite_timestamp/timestamp/main.c)
> > still defines pool_get_major_version(). Nothing calls it anymore, so it
> > can be removed. You can do that when committing; no need for v6.
>
> Ok. Will remove it when committing.
>
> > Also, a reminder about the incompatibility item in the 4.8 release
> > notes.
>
> Thanks for the reminder. It will be handled by our release team.
>
> > Other than that, v5 looks good to me.
>
> > Thanks for the hard work on this!
>
> Thank you for the detailed review! That was really helpful. I
> appreciate it.
>
> I plan to push the two patches separately. I also plan to change the
> 0001 commit message to make it more informative. FYI I'm attaching it.
>
> Regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
>
--
Nadav Shatz
Tailor Brands | CTO
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2026-10-17 09:21:23 | target_session_attrs |
| Previous Message | Tatsuo Ishii | 2026-10-14 01:08:06 | Re: Fix extended-protocol DISCARD handling. |