| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | nadav(at)tailorbrands(dot)com |
| Cc: | pgpool-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Removing support for FE/BE protocol version 2 |
| Date: | 2026-10-13 23:00:04 |
| Message-ID: | 20261014.080004.1610708050654006060.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgpool-hackers |
Hi Nadav,
Thanks for the review!
> Hi,
>
> Thanks for v5!
>
> Agreed on handling protoMajor/protoMinor in pool_get_cp() as a
> separate patch.
>
> One small leftover: the 010 test stub
> (src/test/regression/tests/010.rewrite_timestamp/timestamp/main.c)
> still defines pool_get_major_version(). Nothing calls it anymore, so it
> can be removed. You can do that when committing; no need for v6.
Ok. Will remove it when committing.
> Also, a reminder about the incompatibility item in the 4.8 release
> notes.
Thanks for the reminder. It will be handled by our release team.
> Other than that, v5 looks good to me.
> Thanks for the hard work on this!
Thank you for the detailed review! That was really helpful. I
appreciate it.
I plan to push the two patches separately. I also plan to change the
0001 commit message to make it more informative. FYI I'm attaching it.
Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Koshino Taiki | 2026-10-14 00:57:36 | Fix extended-protocol DISCARD handling. |
| Previous Message | Nadav Shatz | 2026-10-13 11:49:43 | Re: Removing support for FE/BE protocol version 2 |