Re: Row pattern recognition

From: 신성준 <shinsj4653(at)gmail(dot)com>
To: assam258(at)gmail(dot)com
Cc: Tatsuo Ishii <ishii(at)postgresql(dot)org>, jian(dot)universality(at)gmail(dot)com, vik(at)postgresfriends(dot)org, pgsql-hackers(at)postgresql(dot)org, zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com
Subject: Re: Row pattern recognition
Date: 2026-07-18 23:33:18
Message-ID: CACdN0M4_VxGsLOYRya_J+-Xw7YuLmZaWMoYyYvbUQ2cHX5nJdA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Henson, and hackers,

Henson has been mentoring me and suggested I try building and running
this patch, so this is a first-timer's build-and-use note, not a real
review.

I built cf/4460 (v49) on macOS 15 / Apple Silicon (arm64), meson with
cassert and debug. It built without errors. One small thing worth
flagging: it emits two -Wmacro-redefined warnings for INITIAL, in the
generated scanners (backend scan.c and ecpg pgc.c). The new INITIAL
keyword ends up as a token macro (#define INITIAL in gram.h) that
collides with flex's built-in INITIAL start condition (#define INITIAL 0
in the scanner). A plain master build here is warning-clean (no INITIAL
keyword there), so this looks specific to the patch. Seen on clang; not
sure if it's known or turns up on other compilers.

On tests, rpr, rpr_nfa, rpr_explain and rpr_integration pass. rpr_base
has only the RESPECT/IGNORE NULLS wording diff, which looks like the
pending rebase rather than anything real.

I also went beyond the basic example -- the two SKIP modes, quantifier
variants ({2,}, *, a reluctant quantifier, an alternation), and a few
odd inputs (tied values, a NULL mid-run, a single-row partition).
Everything behaved as I'd expect, nothing anomalous.

This was v49, since that's what cfbot has built. Happy to re-run on the
latest after a rebase, on macOS/arm64 if that platform is useful to have
covered.

Best regards,
Seongjun

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2026-07-19 00:50:24 Re: First draft of PG 19 release notes
Previous Message Daniel Gustafsson 2026-07-18 21:08:47 Re: pg_plan_advice: fix parsing underscore in numbers