Re: Row pattern recognition

Hi,

> Hi Henson, and hackers,
>
> Henson has been mentoring me and suggested I try building and running
> this patch, so this is a first-timer's build-and-use note, not a real
> review.

Thanks for the testing.

> I built cf/4460 (v49) on macOS 15 / Apple Silicon (arm64), meson with
> cassert and debug. It built without errors. One small thing worth
> flagging: it emits two -Wmacro-redefined warnings for INITIAL, in the
> generated scanners (backend scan.c and ecpg pgc.c). The new INITIAL
> keyword ends up as a token macro (#define INITIAL in gram.h) that
> collides with flex's built-in INITIAL start condition (#define INITIAL 0
> in the scanner). A plain master build here is warning-clean (no INITIAL
> keyword there), so this looks specific to the patch. Seen on clang; not
> sure if it's known or turns up on other compilers.

Here (Ubuntu 24.0 LTS + bison 3.8.2) I only see enum in gram.h,

# define YYTOKENTYPE
enum yytokentype
{
:
:
INITIAL = 472, /* INITIAL */

In addition you see #define INITIAL in gram.h?

If yes, probably we should consider change "INITIAL" to something like
"INITIAL_P" to avoid the collision?

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp