| From: | JoongHyuk Shin <sjh910805(at)gmail(dot)com> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, Vitaly Davydov <vitprof(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Deadlock detector fails to activate on a hot standby replica |
| Date: | 2026-11-13 02:50:32 |
| Message-ID: | CACSdjfODNjz8iVso5J8E0LfmQjJSfQjJ4sMP5f=FZMFimcNWJA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Xuneng, Vitaly,
I tested v10 on master 48938780c35, built with --enable-cassert
--enable-debug --enable-tap-tests --enable-injection-points. The patches
apply and build without warnings, and src/test/recovery passes. On
master with only the injection points added, the two new
unrelated-wakeup tests fail.
I also woke startup with pg_log_backend_memory_contexts() during a
buffer pin deadlock and a lock deadlock, with
max_standby_streaming_delay = -1. On master, 7 of 8 runs (2 of 2 buffer
pin, 5 of 6 lock) were still stuck 10 to 15 seconds later. v10 resolved
all of them at about the same time as with no wakeup.
The race I reported on v7 is fixed too. I checked it by stopping
startup in gdb inside the window.
LGTM. I'll mark it Ready for Committer.
--
JoongHyuk Shin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2026-11-13 03:16:46 | Re: [PATCH v1 0/2] Preserve input sign across numeric parameter parsing |
| Previous Message | Chao Li | 2026-11-13 02:20:57 | Re: Distinguish EOF from a read error when loading the relcache init file |