| From: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | Vitaly Davydov <vitprof(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, JoongHyuk Shin <sjh910805(at)gmail(dot)com> |
| Subject: | Re: Deadlock detector fails to activate on a hot standby replica |
| Date: | 2026-10-28 09:32:55 |
| Message-ID: | CABPTF7VPHv=PQgmKcjcMZD91yTJ7a493_8stWHh9CQ+Xx2cz2A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi shihao,
On Wed, Oct 28, 2026 at 10:16 AM shihao zhong <zhong950419(at)gmail(dot)com> wrote:
> Hi Xuneng,
>
> Thanks for v10 and for finding the lock case. I tested it and have
> a few notes.
>
> 1. I am able to reproduce the case with your code and when
> it passed deadlock_timeout. And your V10 is able to cancel the
> deadlocked query.
>
> 2. V10 leaves the case where the delay has already passed as it was,
> one wait with no timeout. So the problem in CF 6445 [1] is still
> there.
>
> I think this patch is LGTM.
>
> [1] https://commitfest.postgresql.org/patch/6445/
>
Thanks for your review! I am aware of the patch you referred to and plan to
take a look soon.
--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2026-10-28 09:44:04 | Re: SUM(int2)/SUM(int4) do not detect overflow of the int8 accumulator |
| Previous Message | Jakub Wartak | 2026-10-28 09:12:06 | Re: [(known) BUG] DELETE/UPDATE more than one row in partitioned foreign table |