Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Date: 2026-06-29 23:35:36
Message-ID: akMBSHLlmeeuzK1a@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 29, 2026 at 04:16:59PM -0500, Zsolt Parragi wrote:
> Isn't mentioning pg_settings confusing instead of helpful during a
> server restart? With a reload it can help, but when the server can't
> start, hinting that the user should query pg_settings doesn't seem
> that useful.

Yeah, it is. I don't see a reason why we should be specific about the
location where these parameters are set. One has been setting up
recovery parameters in the GUC machine, so they most likely know where
these strings are.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2026-06-29 23:42:21 Re: PostgreSQL select-only CTE removal is too aggressive?
Previous Message Thomas Munro 2026-06-29 23:34:31 Re: Per-thread leak in ECPG's memory.c