Re: patch to allow disable of WAL recycling

From: Jerry Jelinek <jerry(dot)jelinek(at)joyent(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch to allow disable of WAL recycling
Date: 2018-09-13 20:56:42
Message-ID: CACPQ5FqTeddDX-OURpRtBzBZkfH0ZPMUWx=TCRAZQsbY+7S6rQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Peter,

I'll take a look at that. I had been trying to keep the patch as minimal as
possible, but I'm happy to work through this.

Thanks,
Jerry

On Tue, Sep 11, 2018 at 9:39 AM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> On 10/09/2018 16:10, Jerry Jelinek wrote:
> > Thank you again for running all of these tests on your various hardware
> > configurations. I was not aware of the convention that the commented
> > example in the config file is expected to match the default value, so I
> > was actually trying to show what to use if you didn't want the default,
> > but I am happy to update the patch so the comment matches the default.
> > Beyond that, I am unsure what the next steps are for this proposal.
>
> Could you organize the code so that the block below
>
> /*
> * Initialize info about where to try to recycle to.
> */
>
> isn't executed if recycling is off, since we don't need it.
>
> --
> Peter Eisentraut http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-09-13 21:03:39 Re: pg_dump test instability
Previous Message Alexander Kuzmenkov 2018-09-13 19:36:24 Re: Index Skip Scan