| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jerry Jelinek <jerry(dot)jelinek(at)joyent(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch to allow disable of WAL recycling |
| Date: | 2018-09-11 15:39:35 |
| Message-ID: | 0f2a0559-3bab-2834-661b-4ee8bcb0e241@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/09/2018 16:10, Jerry Jelinek wrote:
> Thank you again for running all of these tests on your various hardware
> configurations. I was not aware of the convention that the commented
> example in the config file is expected to match the default value, so I
> was actually trying to show what to use if you didn't want the default,
> but I am happy to update the patch so the comment matches the default.
> Beyond that, I am unsure what the next steps are for this proposal.
Could you organize the code so that the block below
/*
* Initialize info about where to try to recycle to.
*/
isn't executed if recycling is off, since we don't need it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-11 16:03:44 | Re: StandbyAcquireAccessExclusiveLock doesn't necessarily |
| Previous Message | Tom Lane | 2018-09-11 15:33:02 | Re: StandbyAcquireAccessExclusiveLock doesn't necessarily |