Re: Unhappy about API changes in the no-fsm-for-small-rels patch

On Fri, Apr 26, 2019 at 11:52 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Apr 25, 2019 at 12:39 PM John Naylor
> <john(dot)naylor(at)2ndquadrant(dot)com> wrote:
> >
> > On Wed, Apr 24, 2019 at 1:58 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > <v2 patch>
> >
> > Sorry for not noticing earlier, but this patch causes a regression
> > test failure for me (attached)
> >
>
> Can you please try to finish the remaining work of the patch (I am bit
> tied up with some other things)? I think the main thing apart from
> representation of map as one-byte or one-bit per block is to implement
> invalidation. Also, try to see if there is anything pending which I
> might have missed. As discussed above, we need to issue an
> invalidation for following points: (a) when vacuum finds there is no
> FSM and page has more space now, I think you can detect this in
> RecordPageWithFreeSpace (b) invalidation to notify the existence of
> FSM, this can be done both by vacuum and backend.

Yes, I'll work on it.

--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services