| From: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unhappy about API changes in the no-fsm-for-small-rels patch |
| Date: | 2019-04-18 08:40:06 |
| Message-ID: | CACPNZCsgYGBFNMkPqF4zjwR6cvJzjv7_4QD3_UXQQhHh8doH+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 18, 2019 at 2:48 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> I respect and will follow whatever will be the consensus after
> discussion. However, I request you to wait for some time to let the
> discussion conclude. If we can't get to an
> agreement or one of John or me can't implement what is decided, then
> we can anyway revert it.
Agreed. I suspect the most realistic way to address most of the
objections in a short amount of time would be to:
1. rip out the local map
2. restore hio.c to only checking the last block in the relation if
there is no FSM (and lower the threshold to reduce wasted space)
3. reduce calls to smgr_exists()
Thoughts?
--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2019-04-18 11:50:45 | Question about the holdable cursor |
| Previous Message | Peter Eisentraut | 2019-04-18 08:14:04 | Re: Fix handling of unlogged tables in FOR ALL TABLES publications |