| From: | Kirk Wolak <wolakk(at)gmail(dot)com> |
|---|---|
| To: | Salma Elsayed <salmasayed182003(at)gmail(dot)com> |
| Cc: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, zsolt(dot)parragi(at)percona(dot)com, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: PoC: Simplify recovery after dropping a table by LOGGING the restore LSN |
| Date: | 2026-10-21 12:49:04 |
| Message-ID: | CACLU5mR+2+ZA10vtM8vfZUjU50KHoZGH_B86ikZV0LPh-HynSQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 21, 2026 at 7:18 AM Salma Elsayed <salmasayed182003(at)gmail(dot)com>
wrote:
> Hi Jim and Zsolt,
>
> On Fri, Oct 16, 2026 at 12:25 AM Zsolt Parragi
> <zsolt(dot)parragi(at)percona(dot)com> wrote:
> >
> > If a backend crashes between them the callback doesn't run and we are
> > left with an invalid database without logging it.
> >
> ...
> So I'd like to remove DROP DATABASE from this patch and keep it to
> DROP TABLE and TRUNCATE TABLE, which was the original scope. DROP
> DATABASE could be handled separately in another patch. What do you
> think?
>
+1
Having worked on the original patch, our goal was protecting the table
data.
The attempt to add DROP DATABASE "seemed" like it could come along for the
ride,
but it is clearly a different beast, for the reasons you describe.
Kirk Out!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2026-10-21 13:07:53 | Re: Return pg_control from pg_backup_stop(). |
| Previous Message | Andres Freund | 2026-10-21 12:31:09 | Re: Use a bulk-write buffer access strategy for TOAST inserts |