mislead comments in pg_get_statisticsobjdef_string

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: mislead comments in pg_get_statisticsobjdef_string
Date: 2025-09-25 13:16:47
Message-ID: CACJufxHwVPgeu8o9D8oUeDQYEHTAZGt-J5uaJNgYMzkAW7MiCA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi.

/*
* Internal version for use by ALTER TABLE.
* Includes a tablespace clause in the result.
* Returns a palloc'd C string; no pretty-printing.
*/
char *
pg_get_statisticsobjdef_string(Oid statextid)
{
return pg_get_statisticsobj_worker(statextid, false, false);
}

is the above "tablespace clause" comment wrong?
since there is no "tablespace clause" related to CREATE STATISTICS.

I guess that time, comments were just simply copied from
function pg_get_indexdef_string.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Maxim Orlov 2025-09-25 13:17:24 Use "?=" operator for a contrib makefile in documentation
Previous Message Daniil Davydov 2025-09-25 13:15:50 Re: Fix bug with accessing to temporary tables of other sessions