| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Use "?=" operator for a contrib makefile in documentation |
| Date: | 2025-09-25 13:17:24 |
| Message-ID: | CACG=ezYfbQbrMubg2m_qce_GR9=A86io6UbpJ=c611O=Nv7gEw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
Please give notice to this discussion [0].
I think that the Makefile should be written so that variable values,
specifically, PG_CONFIG, can be given to it from the environment rather
than the make command line. As a result, using the "?=" operator rather
than "=" to set a default value to the PG_CONFIG variable appears more
acceptable.
I'm not sure if this operator has to be changed in the main Postgres
source tree; after all, they're typically built with the kernel.
[0] https://github.com/eulerto/wal2json/pull/290
[1]
https://www.postgresql.org/docs/current/extend-extensions.html#EXTEND-EXTENSIONS-EXAMPLE
--
Best regards,
Maxim Orlov.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Recommend-to-use-PG_CONFIG-from-the-environment-f.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Todd Lang | 2025-09-25 13:32:17 | RE: Supporting non-deterministic collations with tailoring rules. |
| Previous Message | jian he | 2025-09-25 13:16:47 | mislead comments in pg_get_statisticsobjdef_string |