| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Antonin Houska <ah(at)cybertec(dot)at> |
| Subject: | Re: Foreign key validation failure in 18beta1 |
| Date: | 2025-06-01 12:35:08 |
| Message-ID: | CACJufxHdhON_NO29jbKYgPBY=zPEpqbQNA-M4Cs3DBp21SxsaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 30, 2025 at 6:32 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
>
> Kindly take a look at the attached version. I've also added the tests.
> Thanks for your script -- all tests are passing with this patch.
>
hi.
+ * Note that validation should be performed against the referencing
+ * root table only, not its child partitions. See
+ * QueueFKConstraintValidation() for more details.
*/
if (rel->rd_rel->relkind == RELKIND_RELATION &&
currcon->confrelid == pkrelid)
{
AlteredTableInfo *tab;
NewConstraint *newcon;
newcon = (NewConstraint *) palloc0(sizeof(NewConstraint));
....
}
in the comments "referencing" should be "referenced"?
other than that, it looks good.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ryo Kanbayashi | 2025-06-01 12:36:08 | Re: [PATCH] PGSERVICEFILE as part of a normal connection string |
| Previous Message | Daniil Davydov | 2025-06-01 12:21:17 | Re: Speedup truncations of temporary relation forks |