Re: Foreign key validation failure in 18beta1

On Sun, Jun 1, 2025 at 6:05 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> On Fri, May 30, 2025 at 6:32 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> >
[...]
>
> + * Note that validation should be performed against the referencing
> + * root table only, not its child partitions. See
> + * QueueFKConstraintValidation() for more details.
> */
> if (rel->rd_rel->relkind == RELKIND_RELATION &&
> currcon->confrelid == pkrelid)
> {
> AlteredTableInfo *tab;
> NewConstraint *newcon;
> newcon = (NewConstraint *) palloc0(sizeof(NewConstraint));
> ....
> }
>
> in the comments "referencing" should be "referenced"?
>
Yes, fixed in the attached version.

> other than that, it looks good.
>
Thanks for the review.

Regards,
Amul