| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, wangpeng <215722532(at)qq(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dumpall --roles-only interact with other options |
| Date: | 2026-03-02 07:20:24 |
| Message-ID: | CACJufxHVwWs4kha+iP4+LOwLmsRSNjto-QRN1o2erjiScV6AbA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 25, 2026 at 4:09 AM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> Shouldn't these also use pg_log_error + pg_log_error_hint + exit_nicely?
>
Sure.
> Otherwise it looks good to me.
While rebasing, I found that I missed the combination: --statistics
and --no-statistics.
Since pg_dump will error out on this combination, pg_dumpall should too.
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-pg_dumpall-error-out-conflict-options.patch | text/x-patch | 13.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Blessy Thomas | 2026-03-02 07:25:26 | Extension - multilingual_fuzzy_match : Multilingual phonetic matching extension for PostgreSQL |
| Previous Message | Michael Paquier | 2026-03-02 07:17:23 | Re: DOCS - pg_walsummary typo? |