On Fri, Jul 18, 2025 at 5:11 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> Anyway, here's a patch.
>
one minor issue in getDomainConstraints:
for (int i = 0, j = 0; i < ntups; i++)
{
char contype = (PQgetvalue(res, i, i_contype))[0];
....
constraint->contype = *(PQgetvalue(res, i, i_contype));
}
for the same code simplicity,
``constraint->contype = *(PQgetvalue(res, i, i_contype));``
can change to
`` constraint->contype = contype; ``
?
other than that, looks good to me.