| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_dump does not dump domain not-null constraint's comments |
| Date: | 2025-07-17 17:04:36 |
| Message-ID: | 202507171704.ksylf7ifwbz6@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Jul-15, jian he wrote:
> we should let:
> dumpConstraint handles dumping separate "NOT VALID" domain constraints along
> with their comments.
> dumpDomain: handles dumping "inlined" valid (not separate) domain constraints
> together with their comments.
Hmm, okay, but not-null constraints on domain cannot be NOT VALID at
present. I think it would be a useful feature (so that users can make
domains not-null that are used in tables already populated with data),
but first you'd need to implement things so that each table has a
not-null constraint row for the column whose type is the domain that's
being marked not-null.
Anyway, here's a patch.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-pg_dump-include-comments-on-not-null-constraints-.patch | text/x-diff | 14.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-07-17 17:25:27 | Re: Conflict detection for update_deleted in logical replication |
| Previous Message | Andres Freund | 2025-07-17 17:03:25 | Re: simple patch for discussion |