src/test/modules/test_regex/test_regex.c typo issue

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: src/test/modules/test_regex/test_regex.c typo issue
Date: 2023-02-04 07:52:23
Message-ID: CACJufxGBHg-tcZ3EkCaPM_uH9Q_q6cJzdp+K-0pTY=kmoyC30g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
in src/test/modules/test_regex/test_regex.c

/* Report individual info bit states */
for (inf = infonames; inf->bit != 0; inf++)
{
if (cpattern->re_info & inf->bit)
{
if (flags->info & inf->bit)
elems[nresults++] = PointerGetDatum(cstring_to_text(inf->text));
else
{
snprintf(buf, sizeof(buf), "unexpected %s!", inf->text);
elems[nresults++] = PointerGetDatum(cstring_to_text(buf));
}
}
else
{
if (flags->info & inf->bit)
{
snprintf(buf, sizeof(buf), "missing %s!", inf->text);
elems[nresults++] = PointerGetDatum(cstring_to_text(buf));
}
}
}

I think "expected" should be replaced with "missing".
the "missing" should be replaced with "expected".

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-02-04 08:08:42 Re: src/test/modules/test_regex/test_regex.c typo issue
Previous Message Peter Eisentraut 2023-02-04 07:02:47 Re: Remove unused code related to unknown type