Re: src/test/modules/test_regex/test_regex.c typo issue

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: src/test/modules/test_regex/test_regex.c typo issue
Date: 2023-02-04 08:08:42
Message-ID: 1876415.1675498122@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

jian he <jian(dot)universality(at)gmail(dot)com> writes:
> in src/test/modules/test_regex/test_regex.c
> ...
> I think "expected" should be replaced with "missing".
> the "missing" should be replaced with "expected".

It looks correct to me as-is. cpattern->re_info is the
data-under-test, flags->info is the presumed-correct
reference data.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jacktby@gmail.com 2023-02-04 08:59:24 How to implement read operations for my own access method?
Previous Message jian he 2023-02-04 07:52:23 src/test/modules/test_regex/test_regex.c typo issue