Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Tommy Pavlicek <tommypav122(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges
Date: 2023-10-12 03:53:53
Message-ID: CACJufxFrPNGs3Ws7HQLgXqR2YnnDmgGGqtmEULU-nu7oyc13gQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

errmsg("operator attribute \"negator\" cannot be changed if it has
already been set")));
I feel like the above message is not very helpful.

Something like the following may be more helpful for diagnosis.
errmsg("operator %s's attribute \"negator\" cannot be changed if it
has already been set", operatorname)));

when I "git apply", I've noticed some minor whitespace warning.

Other than that, it looks fine.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2023-10-12 04:02:47 Re: Synchronizing slots from primary to standby
Previous Message shveta malik 2023-10-12 03:53:14 Re: Synchronizing slots from primary to standby