| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Tommy Pavlicek <tommypav122(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Subject: | Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges |
| Date: | 2023-10-20 16:33:03 |
| Message-ID: | 3891595.1697819583@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
jian he <jian(dot)universality(at)gmail(dot)com> writes:
> errmsg("operator attribute \"negator\" cannot be changed if it has
> already been set")));
> I feel like the above message is not very helpful.
I think it's okay to be concise about this as long as the operator
we're referring to is the target of the ALTER. I agree that when
we're complaining about some *other* operator, we'd better spell
out which one we mean, and I made some changes to the patch to
improve that.
Pushed after a round of editorialization -- mostly cosmetic
stuff, except for tweaking some error messages. I shortened the
test cases a bit too, as I thought they were somewhat excessive
to have as a permanent thing.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-10-20 16:49:32 | Re: Improve WALRead() to suck data directly from WAL buffers when possible |
| Previous Message | Jeff Davis | 2023-10-20 16:28:17 | Re: Is this a problem in GenericXLogFinish()? |